Fixes from the live tests on git.arzaroth.com #1

Merged

Arzaroth merged 15 commits from feature/live-fixes into master 2026-09-29 22:24:54 +02:00

Conversation 0 Commits 15 Files changed 26 +760 -53

Arzaroth commented 2026-09-29 22:21:54 +02:00

Owner

Copy link

Eight fixes found by running every write command against a real Forgejo, and the max review's fixes on top: local due dates (with a POSIX TZ rule evaluator), pr merge's retry and -d fast-forward, secret and variable delete confirmation, gh-style boolean flags, repo sync on up-to-date and diverged forks, repo list's gh filters, and the milestone in views. Gate: 217 tests.

Eight fixes found by running every write command against a real Forgejo, and the max review's fixes on top: local due dates (with a POSIX TZ rule evaluator), pr merge's retry and -d fast-forward, secret and variable delete confirmation, gh-style boolean flags, repo sync on up-to-date and diverged forks, repo list's gh filters, and the milestone in views. Gate: 217 tests.

Arzaroth added 15 commits 2026-09-29 22:21:54 +02:00

[feature/live-fixes] feat(cli): boolean flags take =true and =false, and --enable-x=false means --disable-x, as gh's do 567ebe1e20

[feature/live-fixes] fix(pr): merge waits while Forgejo is still checking the branch, merge -d fast-forwards the base it switches to, views show the milestone faaa02baae

[feature/live-fixes] fix(secret): secret and variable delete ask first, and take --yes 8251628c3e

[feature/live-fixes] fix(milestone): --due is the end of that day in the local zone, and due dates show as local days; tests run in UTC aaeb838e63

[feature/live-fixes] test: merge retry, the base fast-forwarded after merge -d, the milestone line, due dates across zones 97fea95bb3

[feature/live-fixes] docs: the live test's fixes in the brain, changelog and todo d185d0d65a

[feature/live-fixes] fix(repo): sync says when a fork is already up to date or has diverged instead of passing on Forgejo's 400; list takes gh's --fork, --source, --visibility, --archived and --no-archived, and shows private forks as both 4268698b33

[feature/live-fixes] test: repo sync on an up-to-date and a diverged fork, repo list filters 8de69be68c

[feature/live-fixes] docs: repo sync's up-to-date and diverged cases, repo list filters, the fork tried live e2bfaefb83

[feature/live-fixes] fix(dates): max-review fixes - TZ names are zone files before rules and empty means UTC, a rule without dates takes the US ones, the parser cannot overflow, only regular files are read, the later instant ends a fall-back day, impossible dates and years past 9999 are refused, a bad due date is cleaned 81a58003b8

[feature/live-fixes] fix(pr): max-review fixes - merge -d only touches a clone of the pull request's repository and pulls the base from its remote, branch names with git revision syntax are refused, a 405 'try again later' is retried briefly and explained as conflicts or checking 1d448bdaff

[feature/live-fixes] fix(repo): max-review fixes - sync tells an up-to-date fork from a diverged one by their commits, list takes gh's --language, --topic and --visibility internal d5a9197231

[feature/live-fixes] fix(cli): max-review fixes - booleans take pflag's spellings and -d=false, the last occurrence wins, --draft=false and --prerelease=false mean --publish and --latest 200ebcedc3

[feature/live-fixes] test: max-review gaps - a TZif zone file's footer, local versus UTC days, a fall-back midnight, EST5EDT, impossible dates and years, overflowing TZ rules, merge retry counts, the milestone in issue view, variable delete --yes, every repo list filter, pflag booleans 9c83bc90f1

[feature/live-fixes] docs: the max review's fixes in the brain and changelog 38ff4c927b

Arzaroth merged commit aacbe2ba82 into master 2026-09-29 22:24:54 +02:00

Arzaroth deleted branch feature/live-fixes 2026-09-29 22:24:54 +02:00

Arzaroth referenced this pull request from a commit 2026-09-29 22:24:55 +02:00

Merge pull request 'Fixes from the live tests on git.arzaroth.com' (#1) from feature/live-fixes into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Arzaroth/smith!1

No description provided.